Skip to content

fix : build error - #533

Merged
wineee merged 1 commit into
linuxdeepin:multi-seatfrom
Dami-star:multi-seat
Aug 28, 2025
Merged

wineee merged 1 commit into
linuxdeepin:multi-seatfrom
Dami-star:multi-seat

Conversation

@Dami-star

@Dami-star Dami-star commented Aug 28, 2025 •

Copy link
Copy Markdown
Collaborator

add render enable interface.

cherry-pick form #516

Summary by Sourcery

Add a render enable interface to the Helper class, update onPrepareForSleep logic to use it, and correct the logging category.

New Features:

  • Introduce enableRender() and disableRender() methods to control rendering in Helper.

Bug Fixes:

  • Resolve build errors by implementing the missing render control methods.

Enhancements:

  • Switch logging from treelandCore to qLcHelper in Helper.
  • Invoke render enable/disable before and after hibernation in onPrepareForSleep.

add render enable interface.

cherry-pick form linuxdeepin#516
@Dami-star
Dami-star requested a review from zccrs August 28, 2025 03:40
@sourcery-ai

sourcery-ai Bot commented Aug 28, 2025

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR corrects log categories and introduces explicit render control methods in Helper to streamline enabling/disabling rendering.

Class diagram for updated Helper class with render control methods

classDiagram
    class Helper {
        +void enableRender()
        +void disableRender()
        ...
    }
    Helper --> m_renderWindow: uses
    class m_renderWindow {
        +void setRenderEnabled(bool)
    }
Loading

File-Level Changes

Change Details Files
Standardize log messages to use qLcHelper
  • Replaced qCWarning(treelandCore) with qCWarning(qLcHelper)
  • Replaced qCInfo(treelandCore) with qCInfo(qLcHelper)
src/seat/helper.cpp
Add enableRender/disableRender interface
  • Declared enableRender and disableRender in Helper
  • Implemented enableRender to setRenderEnabled(true)
  • Implemented disableRender to setRenderEnabled(false)
  • Updated onPrepareForSleep to invoke these methods
src/seat/helper.h
src/seat/helper.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Add null checks in enableRender() and disableRender() to avoid potential crashes if m_renderWindow is not initialized.
  • Consider grouping the new enableRender/disableRender declarations with related methods in the header for better organization.
  • Verify that the qLcHelper logging category is properly declared and enabled so your new log statements actually appear.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Add null checks in enableRender() and disableRender() to avoid potential crashes if m_renderWindow is not initialized.
- Consider grouping the new enableRender/disableRender declarations with related methods in the header for better organization.
- Verify that the qLcHelper logging category is properly declared and enabled so your new log statements actually appear.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot

Copy link
Copy Markdown

@Dami-star: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
github-trigger-obs-ci 63ac264 link true /test github-trigger-obs-ci

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wineee
wineee merged commit c53b71a into linuxdeepin:multi-seat Aug 28, 2025
6 of 11 checks passed
@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Dami-star, wineee, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants