Repository navigation
fix: Remove unused config references - #662
Merged
Merged
Conversation
These configuration fields is actually not used in anywhere, and will be removed by recent ddm refactor.
Contributor
Author
|
Paired with linuxdeepin/ddm#58 |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves unused configuration references from the greeter UserModel, simplifying the API and eliminating dead code related to avatar configuration and theme faces directory. Class diagram for UserModel before and after removing unused config referencesclassDiagram
class UserModel_Before {
<<QAbstractListModel>>
%% Q_PROPERTY declarations
int lastIndex
QString lastUser
int count
int disableAvatarsThreshold
bool containsAllUsers
%% Methods
+void setCurrentUserName(QString userName)
+void updateUserLoginState(QString username, bool logined)
+void clearUserLoginState()
+static int disableAvatarsThreshold()
+bool containsAllUsers() const
}
class UserModel_After {
<<QAbstractListModel>>
%% Q_PROPERTY declarations
int lastIndex
QString lastUser
int count
bool containsAllUsers
%% Methods
+void setCurrentUserName(QString userName) noexcept
+void updateUserLoginState(QString username, bool logined)
+void clearUserLoginState()
+bool containsAllUsers() const
}
UserModel_Before <|-- UserModel_After
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since
disableAvatarsThresholdis removed as aQ_PROPERTY, double-check that no QML code still binds to it or expects it onUserModel, as that would now fail at runtime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since `disableAvatarsThreshold` is removed as a `Q_PROPERTY`, double-check that no QML code still binds to it or expects it on `UserModel`, as that would now fail at runtime.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
zccrs
approved these changes
Dec 24, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: calsys456, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These configuration fields is actually not used in anywhere, and will be removed by recent ddm refactor.
Summary by Sourcery
Remove unused user avatar configuration references from the greeter user model.
Enhancements: