Skip to content

fix(dockpreview): drop invalidated wrappers from preview #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zccrs merged 1 commit into from
May 28, 2026
Merged

fix(dockpreview): drop invalidated wrappers from preview #899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/core/qml/DockPreview.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2024 UnionTech Software Technology Co., Ltd.
// SPDX-FileCopyrightText: 2024-2026 UnionTech Software Technology Co., Ltd.
// SPDX-License-Identifier: Apache-2.0 OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only

import QtQuick
Expand Down Expand Up @@ -76,6 +76,18 @@ Item {
}
}

function removeSurface(surfaceWrapper) {
if (!surfaceWrapper)
return;

var index = desiredSurfaces.indexOf(surfaceWrapper);
if (index < 0)
return;

desiredSurfaces.splice(index, 1);
updateModel();
}

function activateWindow(surfaceWrapper) {
console.debug(qLcDockPreview, "activate preview window: ", surfaceWrapper)
Helper.forceActivateSurface(surfaceWrapper)
Expand Down Expand Up @@ -471,6 +483,13 @@ Item {
implicitHeight: root.isHorizontal ? 120 : Math.max(80, Math.min(120, 240 * wrapper.height / wrapper.width))
implicitWidth: root.isHorizontal ? Math.max(80, Math.min(240, 120 * wrapper.width / wrapper.height)) : 240

Connections {
target: wrapper
function onAboutToBeInvalidated() {
listview.model.removeSurface(wrapper)
}
}

ListView.onRemove: {
if (filterSurfaceModel.count) {
isRemoving = true
Expand Down
Loading