refactor(main): resolve code smells via workflow abstraction

[flexiondotorg]

Summary

This refactor addresses six entrenched code smells through workflow abstraction and dependency inversion. The run() function previously contained 288 lines of mode-specific branching, primitive type handling, and tight coupling to the id3 package. By introducing a Workflow interface, mode-specific logic is now encapsulated in isolated implementations (Hugo, Standalone), reducing run() to 63 lines of orchestration code. The id3 package no longer imports the CLI package, eliminating circular dependency risk. Duplicated style declarations are consolidated in a shared location.

Changes

• Extract Workflow interface defining mode-specific operations (build, validate, apply)
• Implement HugoWorkflow and StandaloneWorkflow with isolated mode logic
• Decompose run() from 288 lines to 63 lines via workflow delegation
• Invert id3 package dependencies: artwork logging callbacks replace cli package imports
• Consolidate duplicated style declarations into shared cli package
• Unify loose metadata variables into TagInfo struct
• Remove dead code (unused ctx assignment in encoder)
• Reduce main_test.go by 618 lines via simplified test surface

Testing

• All existing tests pass (mode-specific workflows tested in isolation)
• HugoWorkflow verified with comprehensive template and metadata tests
• StandaloneWorkflow verified with standalone-specific validation and application tests
• Integration tests simplified by workflow abstraction; call paths unchanged

[cubic-dev-ai]

3 issues found across 13 files

Confidence score: 3/5

• There are concrete validation gaps in cmd/jivedrop/hugo.go and cmd/jivedrop/standalone.go: non-IsNotExist/non-ENOENT os.Stat errors are not handled, so unreadable/inaccessible paths can pass checks and fail later at runtime.
• This creates user-facing failure risk (late errors instead of early validation), which keeps this in a moderate-risk range rather than a safe-to-merge-without-follow-up case.
• The cmd/jivedrop/main.go issue is lower severity but still visible: background goroutine cover-art prints can interfere with the Bubble Tea progress UI output.
• Pay close attention to cmd/jivedrop/hugo.go, cmd/jivedrop/standalone.go, and cmd/jivedrop/main.go - validation should reject inaccessible files early, and UI logging should not clash with the progress renderer.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="cmd/jivedrop/hugo.go">

<violation number="1" location="cmd/jivedrop/hugo.go:32">
P2: Handle non-`IsNotExist` `os.Stat` errors during validation; unreadable files currently pass validation and fail later.</violation>
</file>

<file name="cmd/jivedrop/standalone.go">

<violation number="1" location="cmd/jivedrop/standalone.go:32">
P2: Handle non-ENOENT `os.Stat` errors here; inaccessible audio or cover paths currently pass validation.</violation>
</file>

<file name="cmd/jivedrop/main.go">

<violation number="1" location="cmd/jivedrop/main.go:222">
P2: Avoid printing cover-art status from the background goroutine while the Bubble Tea progress UI is running.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

0 issues found across 5 files (changes from recent commits).

_{Requires human review: Large architectural refactor (+2010 lines) restructuring core logic, metadata handling, and execution flow; requires human review for verification of structural changes.}