refactor: remove TUI auto-spawn and integrate llm-agents codex #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove support for spawning TUI process from CLI when running combo. Now `coco combo run` requires TUI to be already running with a valid session socket. This simplifies the architecture and removes the need for COCO_TUI_BIN environment variable and --ignore-workspace-scripts flag.
Add llm-agents codex package configured with jail-nix to provide a secure, isolated execution environment. The jailed codex has access to ~/.codex and includes all necessary development tools and Rust toolchain dependencies.
Create a separate ci shell output with only dev packages to reduce CI environment dependencies. Update GitHub Actions to use the ci profile instead of the default stable profile.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #178 +/- ##
==========================================
- Coverage 48.12% 46.31% -1.81%
==========================================
Files 105 108 +3
Lines 27916 30066 +2150
==========================================
+ Hits 13435 13926 +491
- Misses 14481 16140 +1659 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove TUI auto-spawn:
combo runnow requires an existing TUI session (viaCOCO_SESSION_SOCK) instead of auto-spawning one--ignore-workspace-scriptsflag and relatedCOCO_TUI_BINenv handlingIntegrate llm-agents codex: Added
jail-nixandllm-agents.nixdependencies toflake.nixMotivation
Removing TUI auto-spawn simplifies the architecture - the CLI now focuses on client-server communication via session sockets, making the flow more explicit and testable. The codex integration enables safer, isolated tool execution.