perf: reduce CPU usage by caching progress bar image#6
Open
CoSNaYe wants to merge 1 commit intolion9453:mainfrom
Open
perf: reduce CPU usage by caching progress bar image#6CoSNaYe wants to merge 1 commit intolion9453:mainfrom
CoSNaYe wants to merge 1 commit intolion9453:mainfrom
Conversation
- Extract MenuBarProgressBars as separate Equatable view to prevent unnecessary NSImage regeneration on every render - Extract RefreshButton to isolate animation state from parent view - Animation no longer triggers full view tree redraws Fixes high CPU usage (~10%) caused by continuous image regeneration during refresh animation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MenuBarProgressBarsas separateEquatableview to prevent unnecessaryNSImageregeneration on every renderRefreshButtonto isolate animation state from parent view, so animation no longer triggers full view tree redrawsTest plan
🤖 Generated with Claude Code