Generalize the nbsp/dash punctuation rule; add missing tooltips - #97
Merged
Merged
Conversation
Extends the non-breaking-space treatment (nbsp before ?/!, nbsp around a
standalone "-" or " — ") from the one bulk-export sentence to all 767
strings in en.json plus their two HTML fallback duplicates. Applied via
script, not by hand, and verified exhaustively: zero remaining unconverted
instances, and spot-checks confirm word-internal hyphens ("on-demand"),
scale-formula hyphens ("W-H-W-W-W-H-W"), tight em-dashes used as prose
punctuation ("comma—incomplete"), and progression names that use em-dash
as a compact chord-to-chord joiner ("I—V—vi—IV") are all untouched - none
of those had a breakable space to protect in the first place. Scope is
English only, per the earlier PR's reasoning about other locales' own
typographic conventions.
Also fixes four tooltip gaps found along the way:
- "Download all .progression/MIDI files" read as duplicates of the
bulk-catalogue link below them. Relabeled to "Download this
progression's ... files" and gave each a tooltip clarifying it covers
every variant, context-aware (progression vs MIDI).
- The MPC Pads tab had no tooltip explaining what it does.
- Each variant's small download icon tooltip just said "Download" -
now names the file type, also context-aware (progression vs MIDI),
since the same icon downloads different formats depending on the
active tab.
buttons.download became unused once the variant-icon tooltip moved to
its own key; removed from all six locales.
fr/es/de/it/pt tooltip and button-label translations are drafts, not
native-reviewed. The nbsp sweep itself is English-only, not extended to
the other locales' own description text.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EwQCigYZxdGBW3kPWnMMgF
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Punctuation generalization (per your "generalize the punctuation rule" request, scoped to include the 51 theory/description strings): the non-breaking-space treatment from the bulk-export hint (PR #96) now applies to all 767 strings in
en.jsonplus their two HTML fallback duplicates (app.subtitle,chordMatcher.description). Applied via script rather than by hand, and exhaustively verified: zero remaining plain" - ", zero remaining plain" — ", zero?/!without a preceding nbsp. Also caught one case not covered by the original hyphen rule: a spaced em-dash inapp.subtitlegets the same treatment, while the 172 tight em-dashes elsewhere (prose likecomma—incomplete, and progression names likeI—V—vi—IVthat use em-dash as a compact chord-joiner) are correctly left alone - there's no breakable space there to protect. Scope is English only; the other five locales keep their own typographic conventions untouched, same reasoning as PR #96.Tooltip fixes, found while working through this:
downloadAllBtn's two labels ("Download all .progression/MIDI files") read as duplicates of the bulk-catalogue link below them. Relabeled to "Download this progression's ... files" with a new tooltip clarifying it covers every variant - context-aware between progression and MIDI.buttons.downloadbecame unused once the variant-icon tooltip moved to its own key; removed from all six locales.fr/es/de/it/pt translations are drafts, not native-reviewed.
Test plan
node -c app.jsand JSON validation on all six locale files🤖 Generated with Claude Code
https://claude.ai/code/session_01EwQCigYZxdGBW3kPWnMMgF
Generated by Claude Code