Skip to content

Conversation

@kiranraoboinapally
Copy link
Contributor

@kiranraoboinapally kiranraoboinapally commented Apr 26, 2025

Updated the GitHub Actions workflow to run unit tests after building the project and upload the test results as artifacts, even if the tests fail. This helps in easily identifying and debugging issues in the code.
Fixes #10.

…e target/

Updated the GitHub Actions workflow to run unit tests after building the project and upload the test results as artifacts, even if the tests fail. This helps in easily identifying and debugging issues in the code.
actions/upload-artifact@v3
Copy link
Contributor Author

@kiranraoboinapally kiranraoboinapally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CatarinaGamboa Is it ok?

@CatarinaGamboa CatarinaGamboa self-requested a review April 26, 2025 15:44
Copy link
Collaborator

@CatarinaGamboa CatarinaGamboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, you can squash and merge.

Let's try to improve this process contributing process following the instructions in the README. Especially:

  1. When creating a PR follow the template that is usually automatic when you create a PR for a branch. This template includes a description of what you did and also includes a section to inform us of how you tested the issue.
  2. When the PR is ready for review, please use Reviewers to request a review from another author/contributer - you can select me, and I will review the PR

@kiranraoboinapally kiranraoboinapally changed the title Workflow Workflow Fixes: #7 Apr 26, 2025
@kiranraoboinapally kiranraoboinapally changed the title Workflow Fixes: #7 Workflow Apr 26, 2025
Copy link
Contributor Author

@kiranraoboinapally kiranraoboinapally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes : #10
unable to see merge! option over here? what could it be?

@CatarinaGamboa CatarinaGamboa merged commit e54cc9d into liquid-java:main Apr 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infrastructure: Add tests to Github Workflow

2 participants