-
Notifications
You must be signed in to change notification settings - Fork 0
Workflow #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow #20
Conversation
…e target/ Updated the GitHub Actions workflow to run unit tests after building the project and upload the test results as artifacts, even if the tests fail. This helps in easily identifying and debugging issues in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CatarinaGamboa Is it ok?
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, you can squash and merge.
Let's try to improve this process contributing process following the instructions in the README. Especially:
- When creating a PR follow the template that is usually automatic when you create a PR for a branch. This template includes a description of what you did and also includes a section to inform us of how you tested the issue.
- When the PR is ready for review, please use
Reviewersto request a review from another author/contributer - you can select me, and I will review the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes : #10
unable to see merge! option over here? what could it be?
Updated the GitHub Actions workflow to run unit tests after building the project and upload the test results as artifacts, even if the tests fail. This helps in easily identifying and debugging issues in the code.
Fixes #10.