Fix Single Equality Simplification #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in the expression simplification logic where an expression, e.g.,
x == 1was being simplified totrue, since the variablexwas replaced with its known value1, resulting in the tautology1 == 1which would then get folded totrue.This would then result in error messages such as "
trueis not a subtype of#x_0 < 0".This was fixed in the
VariableResolverby checking if the expression we want to extract the variables from is a single top-level equality and, in this case, don't addx -> 1to the variable map.Also added some tests for the
VariableResolverand an extra test case for this case in theExpressionSimplifierTest.