Skip to content

Prevent Index Out-Of-Bounds in Function Call With Empty Args #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcosta358 merged 2 commits into from
Nov 13, 2025
Merged

Prevent Index Out-Of-Bounds in Function Call With Empty Args #117

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e09ef3
Prevent Index-Out-Of-Bounds in Function Call
rcosta358 Nov 13, 2025
52647bc
Add Empty Argument Check For Alias Calls
rcosta358 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions liquidjava-verifier/src/main/java/liquidjava/rj_language/visitors/CreateASTVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import liquidjava.rj_language.ast.LiteralString;
import liquidjava.rj_language.ast.UnaryExpression;
import liquidjava.rj_language.ast.Var;
import liquidjava.rj_language.parsing.ParsingException;
import liquidjava.utils.Utils;

import org.antlr.v4.runtime.tree.ParseTree;
Expand Down Expand Up @@ -63,7 +64,7 @@ public CreateASTVisitor(String prefix) {
this.prefix = prefix;
}

public Expression create(ParseTree rc) {
public Expression create(ParseTree rc) throws ParsingException {
if (rc instanceof ProgContext)
return progCreate((ProgContext) rc);
else if (rc instanceof StartContext)
Expand All @@ -84,20 +85,20 @@ else if (rc instanceof LiteralContext)
return null;
}

private Expression progCreate(ProgContext rc) {
private Expression progCreate(ProgContext rc) throws ParsingException {
if (rc.start() != null)
return create(rc.start());
return null;
}

private Expression startCreate(ParseTree rc) {
private Expression startCreate(ParseTree rc) throws ParsingException {
if (rc instanceof StartPredContext)
return create(((StartPredContext) rc).pred());
// alias and ghost do not have evaluation
return null;
}

private Expression predCreate(ParseTree rc) {
private Expression predCreate(ParseTree rc) throws ParsingException {
if (rc instanceof PredGroupContext)
return new GroupExpression(create(((PredGroupContext) rc).pred()));
else if (rc instanceof PredNegateContext)
Expand All @@ -112,7 +113,7 @@ else if (rc instanceof IteContext)
return create(((PredExpContext) rc).exp());
}

private Expression expCreate(ParseTree rc) {
private Expression expCreate(ParseTree rc) throws ParsingException {
if (rc instanceof ExpGroupContext)
return new GroupExpression(create(((ExpGroupContext) rc).exp()));
else if (rc instanceof ExpBoolContext) {
Expand All @@ -124,7 +125,7 @@ else if (rc instanceof ExpBoolContext) {
}
}

private Expression operandCreate(ParseTree rc) {
private Expression operandCreate(ParseTree rc) throws ParsingException {
if (rc instanceof OpLiteralContext)
return create(((OpLiteralContext) rc).literalExpression());
else if (rc instanceof OpArithContext)
Expand All @@ -143,7 +144,7 @@ else if (rc instanceof OpGroupContext)
return null;
}

private Expression literalExpressionCreate(ParseTree rc) {
private Expression literalExpressionCreate(ParseTree rc) throws ParsingException {
if (rc instanceof LitGroupContext)
return new GroupExpression(create(((LitGroupContext) rc).literalExpression()));
else if (rc instanceof LitContext)
Expand All @@ -158,20 +159,24 @@ else if (rc instanceof VarContext) {
}
}

private Expression functionCallCreate(FunctionCallContext rc) {
private Expression functionCallCreate(FunctionCallContext rc) throws ParsingException {
if (rc.ghostCall() != null) {
GhostCallContext gc = rc.ghostCall();
List<Expression> le = getArgs(gc.args());
String name = Utils.qualifyName(prefix, gc.ID().getText());
return new FunctionInvocation(name, le);
List<Expression> args = getArgs(gc.args());
if (args.isEmpty())
throw new ParsingException("Ghost call cannot have empty arguments");
return new FunctionInvocation(name, args);
} else {
AliasCallContext gc = rc.aliasCall();
List<Expression> le = getArgs(gc.args());
return new AliasInvocation(gc.ID_UPPER().getText(), le);
List<Expression> args = getArgs(gc.args());
if (args.isEmpty())
throw new ParsingException("Alias call cannot have empty arguments");
return new AliasInvocation(gc.ID_UPPER().getText(), args);
}
}

private List<Expression> getArgs(ArgsContext args) {
private List<Expression> getArgs(ArgsContext args) throws ParsingException {
List<Expression> le = new ArrayList<>();
if (args != null)
for (PredContext oc : args.pred()) {
Expand All @@ -180,7 +185,7 @@ private List<Expression> getArgs(ArgsContext args) {
return le;
}

private Expression literalCreate(LiteralContext literalContext) {
private Expression literalCreate(LiteralContext literalContext) throws ParsingException {
if (literalContext.BOOL() != null)
return new LiteralBoolean(literalContext.BOOL().getText());
else if (literalContext.STRING() != null)
Expand Down