Refactor Diagnostics #119
Merged
Refactor Diagnostics #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatarinaGamboa
approved these changes
Nov 14, 2025
| * Base class for all LiquidJava errors | ||
| */ | ||
| public abstract class LJError { | ||
| public abstract class LJError extends LJDiagnostic { |
| tc.getContext().addVarToContext(name, r, new Predicate(), e); | ||
| tc.getContext().addVarToContext(nameOld, r, new Predicate(), e); | ||
| // TODO REVIEW!! | ||
| // what is it for? |
Collaborator
There was a problem hiding this comment.
we can remove these comments afterwards or actually give a comment for what we are doing here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #110.
It refactors errors and warnings and also gives them a better look.
Additional Improvements
true && ...from found ghost statesNext Steps
Allow for multiple errors by instead of stopping verification when an error is found, throw the error and catch it on visitors (
visitCtMethod,visitCtClass,visitCtField), add it to the collection and keep the verification going.