Java Compilation Warning #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This approach is not ideal since a compilation error in a single file causes the whole verification to be skipped for the whole directory.
CatarinaGamboa
approved these changes
Nov 21, 2025
| launcher.getEnvironment().setComplianceLevel(8); | ||
| launcher.run(); | ||
|
|
||
| boolean buildSuccess = launcher.getModelBuilder().build(); |
Collaborator
There was a problem hiding this comment.
This always feels like magic trying to find the right words haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a condition in the
CommandLineLauncherthat reports a warning if the Java compilation fails, to alert the user that the LiquidJava verification might be affected by it. Added a custom warning class for this case.liquidjava/liquidjava-verifier/src/main/java/liquidjava/api/CommandLineLauncher.java
Lines 59 to 62 in da2bfce
When using the LiquidJava extension, this warning is only visible in the problems tab and in the webview, not in the editor itself, since we can't provide a location for the error.