Simplification Fixes #125
Merged
Simplification Fixes #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter out variables that only appear in their own definition.
Collaborator
Author
|
The expression |
- Ignore unused variable equalities in VariableResolver, only extracts the variables actually used in the expression (excluding its own definitions) - Improves ExpressionSimplifier by collapsing duplicate conjuctions (e.g. x && x => x)
Fixed by tracking previous origins in constant propagation
Variable nodes should have origin nodes so when expressions are simplified in multiple passes, previous simplifications are preserved
CatarinaGamboa
approved these changes
Dec 10, 2025
Collaborator
CatarinaGamboa
left a comment
CatarinaGamboa
left a comment
There was a problem hiding this comment.
Are we following any known algorithms for the constant propagation? We should compare with them in the writing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the simplification of the predicates.
x && x→x) as well as symmetrical ones (x == y && y == x→x == y)foundbut alsoexpectedpredicate in refinement errorsAlso added tests such as:
x == 1→x == 1(does not simplify)x == 1 && x == 1→x == 1(collapse duplicate)x == y && y == x→x == y(collapse symmetrical)x == 1 && y == 2→x == 1 && y == 2(does not simplify)x == -y && y == a / b && a == 6 && b == 3→x == -y && y == 2→x == -2(two simplifications until fixed point)