Skip to content

Fix massive memory leak #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GUIpsp merged 1 commit into from
Dec 1, 2024
Merged

Fix massive memory leak #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions liquidjava-verifier/src/main/java/liquidjava/smt/SMTEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,16 @@ public void verifySubtype(Predicate subRef, Predicate supRef, Context c)

try {
Expression exp = toVerify.getExpression();
TranslatorToZ3 tz3 = new TranslatorToZ3(c);
// com.microsoft.z3.Expr
Expr<?> e = exp.eval(tz3);
Status s = tz3.verifyExpression(e);
if (s.equals(Status.SATISFIABLE)) {
// System.out.println("result of SMT: Not Ok!");
throw new TypeCheckError(subRef + " not a subtype of " + supRef);
Status s;
try (TranslatorToZ3 tz3 = new TranslatorToZ3(c)) {
// com.microsoft.z3.Expr
Expr<?> e = exp.eval(tz3);
s = tz3.verifyExpression(e);

if (s.equals(Status.SATISFIABLE)) {
// System.out.println("result of SMT: Not Ok!");
throw new TypeCheckError(subRef + " not a subtype of " + supRef);
}
}
// System.out.println("result of SMT: Ok!");

Expand Down
8 changes: 6 additions & 2 deletions liquidjava-verifier/src/main/java/liquidjava/smt/TranslatorToZ3.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

import liquidjava.processor.context.AliasWrapper;

public class TranslatorToZ3 {
public class TranslatorToZ3 implements AutoCloseable {

private com.microsoft.z3.Context z3 = new com.microsoft.z3.Context();
private Map<String, Expr<?>> varTranslation = new HashMap<>();
Expand All @@ -37,7 +37,6 @@ public TranslatorToZ3(liquidjava.processor.context.Context c) {
TranslatorContextToZ3.addGhostStates(z3, c.getGhostState(), funcTranslation);
}

@SuppressWarnings("unchecked")
public Status verifyExpression(Expr<?> e) throws Exception {
Solver s = z3.mkSolver();
// s.add((BoolExpr) e.eval(this));
Expand Down Expand Up @@ -266,4 +265,9 @@ public Expr<?> makeIte(Expr<?> c, Expr<?> t, Expr<?> e) {
return z3.mkITE((BoolExpr) c, t, e);
throw new RuntimeException("Condition is not a boolean expression");
}

@Override
public void close() throws Exception {
z3.close();
}
}