-
Notifications
You must be signed in to change notification settings - Fork 33
Simplify Expressions #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows simplification steps to be expanded by keeping track of their origin nodes, for both constant propagation and constant folding
alcides
requested changes
Oct 6, 2025
Collaborator
alcides
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me in general. There are a few minor points that you can take a look at, that might improve the code quality.
liquidjava-verifier/src/main/java/liquidjava/processor/refinement_checker/TypeChecker.java
Outdated
Show resolved
Hide resolved
liquidjava-verifier/src/main/java/liquidjava/rj_language/ast/Expression.java
Show resolved
Hide resolved
liquidjava-verifier/src/main/java/liquidjava/rj_language/opt/VariableResolver.java
Show resolved
Hide resolved
...idjava-verifier/src/main/java/liquidjava/rj_language/opt/derivation_node/DerivationNode.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Thanks for the review! |
alcides
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR aims to solve issue #58, by applying constant propagation and folding to the AST after a refinement error is found, to simplify the error message shown to the user.
This simplification is done in a way that allows simplification steps to be expanded or collapsed by keeping track of their origin nodes, which can later be used in the VS Code extension, by serializing the derivation tree to JSON.
Additions
VariableResolver- extracts variables with constant values from the AST and stores them in a HashMapConstantPropagation- substitutes variables with their constant values from that HashMapConstantFolding- simplifies expressions by evaluating nodes with constant valuesExpressionSimplifier- combines propagation and folding and simplifies the derivation tree by removing redundant conjuncts (e.g., x && true, x == x)DerivationNode,ValDerivationNode,BinaryDerivationNode,UnaryDerivationNode,VarDerivationNode- nodes that form the derivation treeExpressionSimplifierTest- tests generated by Claude Sonnet 4.5Example