Skip to content

Conversation

@rcosta358
Copy link
Collaborator

@rcosta358 rcosta358 commented Nov 4, 2025

This is an improvement to #66. In external refinements, instead of just checking the name and parameter count of methods, we now check their whole signatures, including name, parameter count, parameter types and return type.

When a method cannot be found with the exact signature, a list of methods with the same name is provided in the error message, if available.

Example:

Found Error: Could not find method 'int acquire()' for 'java.util.concurrent.Semaphore'
Available overloads:
  void acquire()
  void acquire(int)

@rcosta358 rcosta358 self-assigned this Nov 4, 2025
@rcosta358 rcosta358 added the enhancement New feature or request label Nov 4, 2025
Copy link
Collaborator

@CatarinaGamboa CatarinaGamboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This is very helpful and the error message is awesome 🎉

@rcosta358 rcosta358 merged commit 2916690 into liquid-java:main Nov 5, 2025
1 check passed
@rcosta358 rcosta358 deleted the check-method-sigs-in-ext-refs branch November 8, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request error messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants