fixed bug while clicking 'Connect' button w/o properly value in 'filename' field#85
Open
am1goo wants to merge 1 commit intolitedb-org:masterfrom
Open
fixed bug while clicking 'Connect' button w/o properly value in 'filename' field#85am1goo wants to merge 1 commit intolitedb-org:masterfrom
am1goo wants to merge 1 commit intolitedb-org:masterfrom
Conversation
Author
|
similar to #83 but with additional checks about file existence and user-experienced message box |
Author
|
@mbdavid any updates? What do you think about this fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I see, there is no checks about correct value in 'filename' field.
In this case I can get unhandled exception if I click "Connect" button with empty string in this field