Update FROM in dockerfile and Electron version in package.json#3
Open
bramnet wants to merge 2 commits into
Open
Update FROM in dockerfile and Electron version in package.json#3bramnet wants to merge 2 commits into
bramnet wants to merge 2 commits into
Conversation
Updated FROM so the needed python arguments during npm can run correctly (required version 3.6, previous had 3.5).
Electron version 7.1.2 is no longer available (returns 404 during build). Upped version number to 17.2, build was successful on docker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into issues during building in docker.
After some trial and error, identified the issues and was able to resolve them.
Tested on Arm64 (Raspberry Pi 4)