Feat/required langsmith observability

[liupeirong]

No description provided.

[github-actions]

✅ Looks Good

Overall: Clean implementation of optional LangSmith observability (F06). No blocking issues found.

Summary

Dimension	Findings
Correctness	0
Security	0
Reliability	0
Test coverage	0 gaps

Observations (non-blocking)

1. Design note — tracing override behavior (src/vimai/config.py:47-48): _configure_langsmith_tracing() unconditionally sets LANGSMITH_TRACING=true when a key is present, even if the user explicitly set it to false. This means the only way to disable tracing is to remove the API key. This is consistent with the documented feature spec ("vimai enables tracing automatically when the key is present"), so flagging for awareness only.

2. _PROJECT_ROOT fragility (src/vimai/config.py:11): Path(__file__).resolve().parents[2] assumes source layout when installed. The .exists() guard in _load_dotenv_files makes this safe at runtime, but won't find the project .env if installed as a wheel. Acceptable since users are expected to run from the checkout.

Positives

• Good separation: env loading → validation → tracing config
• override=False in dotenv prevents clobbering user-set env vars
• API key deliberately excluded from Config dataclass (no secret leakage)
• Tests use monkeypatch and tmp_path for proper isolation
• Documentation (README, config reference table) updated in sync

Generated by Agentic PR Review for issue #13 · opus46 2.2M · ◷