feat(agents): add external agent runner

[liupeirong]

No description provided.

[github-actions]

Generated by Agentic PR Review for issue #14 · opus46 3.9M

[github-actions]

Reliability — subprocess.run is called without a timeout parameter. A misbehaving or hanging external agent will block vimai indefinitely with no way for the user to recover (Vim will appear frozen).

Consider adding a generous default timeout (e.g. 120s) or making it configurable:

result = subprocess.run(
    [str(wrapper), "--prompt-file", str(prompt_path)],
    capture_output=True,
    check=False,
    encoding="utf-8",
    text=True,
    timeout=120,
)

Catch subprocess.TimeoutExpired alongside the existing OSError handler and raise a clear ExternalAgentError.

[github-actions]

✅ Looks Good

No new issues found. The external agent runner is well-implemented and production-ready.

Key strengths

• Security: Agent name regex prevents path traversal; no shell=True; prompt passed via temp file
• Reliability: 120s subprocess timeout; temp file cleanup in finally
• Correctness: Clear fallback flow (prompt-only → external → error); user-facing error messages
• Testing: Comprehensive coverage across wrapper discovery, timeout, cleanup, error paths, and CLI routing

Previously raised items

Thread	Status
UX regression on missing env var (cli.py)	Resolved by reviewer
Subprocess timeout (external.py)	✅ Fixed — 120s timeout implemented

No actionable findings to add.

Generated by Agentic PR Review for issue #14 · opus46 4.9M · ◷