Skip to content

Support moving participant to another room#473

Merged
cnderrauber merged 3 commits into
mainfrom
move_participant
May 13, 2025
Merged

Support moving participant to another room#473
cnderrauber merged 3 commits into
mainfrom
move_participant

Conversation

@cnderrauber

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented May 9, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b78c220

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
livekit-server-sdk Minor
agent-dispatch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds functionality to move a participant from one room to another in the LiveKit server SDK and updates the dependency for the livekit protocol.

  • Added the moveParticipant method with corresponding documentation and RPC call.
  • Updated the "@livekit/protocol" dependency version in package.json.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
packages/livekit-server-sdk/src/RoomServiceClient.ts Added moveParticipant method and updated documentation.
packages/livekit-server-sdk/package.json Upgraded @livekit/protocol dependency version.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

packages/livekit-server-sdk/src/RoomServiceClient.ts:260

  • The identifier 'svc' is used in the RPC call but its declaration is not visible in this diff. Please ensure 'svc' is defined or imported in the class context to avoid runtime errors.
svc,

Comment on lines +254 to +256
* @param room -
* @param identity -
* @param destinationRoom - the room to move the participant to

Copilot AI May 9, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The parameter documentation for 'room' and 'identity' in the moveParticipant method uses placeholders. Consider providing more detailed descriptions to improve clarity.

Suggested change
* @param room -
* @param identity -
* @param destinationRoom - the room to move the participant to
* @param room - the name of the room the participant is currently in
* @param identity - the unique identifier of the participant to be moved
* @param destinationRoom - the name of the room to move the participant to

Copilot uses AI. Check for mistakes.
@cnderrauber cnderrauber merged commit d842f5d into main May 13, 2025
13 checks passed
@cnderrauber cnderrauber deleted the move_participant branch May 13, 2025 00:15
@github-actions github-actions Bot mentioned this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants