Support moving participant to another room#473
Conversation
🦋 Changeset detectedLatest commit: b78c220 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This pull request adds functionality to move a participant from one room to another in the LiveKit server SDK and updates the dependency for the livekit protocol.
- Added the moveParticipant method with corresponding documentation and RPC call.
- Updated the "@livekit/protocol" dependency version in package.json.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/livekit-server-sdk/src/RoomServiceClient.ts | Added moveParticipant method and updated documentation. |
| packages/livekit-server-sdk/package.json | Upgraded @livekit/protocol dependency version. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
packages/livekit-server-sdk/src/RoomServiceClient.ts:260
- The identifier 'svc' is used in the RPC call but its declaration is not visible in this diff. Please ensure 'svc' is defined or imported in the class context to avoid runtime errors.
svc,
| * @param room - | ||
| * @param identity - | ||
| * @param destinationRoom - the room to move the participant to |
There was a problem hiding this comment.
[nitpick] The parameter documentation for 'room' and 'identity' in the moveParticipant method uses placeholders. Consider providing more detailed descriptions to improve clarity.
| * @param room - | |
| * @param identity - | |
| * @param destinationRoom - the room to move the participant to | |
| * @param room - the name of the room the participant is currently in | |
| * @param identity - the unique identifier of the participant to be moved | |
| * @param destinationRoom - the name of the room to move the participant to |
No description provided.