Skip to content

Add warning on using the sdk with hot reloads #478

Merged
Shubhrakanti merged 3 commits into
mainfrom
shubhra/add-warning-on-hot-reloads
May 14, 2025
Merged

Add warning on using the sdk with hot reloads #478
Shubhrakanti merged 3 commits into
mainfrom
shubhra/add-warning-on-hot-reloads

Conversation

@Shubhrakanti

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented May 14, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a1c67ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Shubhrakanti Shubhrakanti requested a review from davidzhao May 14, 2025 06:20
Comment thread README.md Outdated

### Warning

Avoid running this with hot reloads (ex. [bun's hot reload](https://bun.sh/guides/http/hot)). This is known to cause issues.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Avoid running this with hot reloads (ex. [bun's hot reload](https://bun.sh/guides/http/hot)). This is known to cause issues.
Avoid running this with hot reloads (ex. [bun's hot reload](https://bun.sh/guides/http/hot)). This is known to cause issues with WebRTC connectivity

@Shubhrakanti Shubhrakanti merged commit 494a415 into main May 14, 2025
16 checks passed
@Shubhrakanti Shubhrakanti deleted the shubhra/add-warning-on-hot-reloads branch May 14, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants