Skip to content

Fix memory leak of AudioSource #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
typester merged 3 commits into from
Jun 16, 2025
Merged

Fix memory leak of AudioSource #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f41daa6
add close method to track
typester Jun 2, 2025
8a1a86e
fix example as well
typester Jun 2, 2025
523f0f4
Create selfish-moons-tie.md
typester Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/selfish-moons-tie.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"example-publish-wav": patch
"@livekit/rtc-node": patch
---

Fix memory leak of AudioSource
1 change: 1 addition & 0 deletions examples/publish-wav/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ while (written < dataSize) {
}
await source.waitForPlayout();
// release resources allocated for audio publishing
await track.close();
await source.close();

await room.disconnect();
Expand Down
4 changes: 4 additions & 0 deletions packages/livekit-rtc/src/track.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ export abstract class Track {
get muted(): boolean | undefined {
return this.info?.muted;
}

async close() {

@lukasIO lukasIO Jun 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have a optional boolean here to also close the source when closing the track? e.g.
async close(closeSource = true) {

@typester typester Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shubhrakanti @bcherry I'm not familiar with JS side but this sounds fair to me. What do you think?

I'm going to merge this pr but I'm open to implement this in a different pr

@Shubhrakanti Shubhrakanti Jun 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me!

@typester typester Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will create an other pr for it!

this.ffi_handle.dispose();
}
}

export class LocalAudioTrack extends Track {
Expand Down
Loading