Add support for destination_country in outbound trunk#489
Merged
Conversation
🦋 Changeset detectedLatest commit: 7ce75ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dennwc
approved these changes
Jun 6, 2025
…' into benjamin/SIP_destination_country
davidzhao
reviewed
Jun 6, 2025
| authPassword?: string; | ||
| destinationCountry?: string; | ||
| name?: string; | ||
| metadata?: string; |
Member
There was a problem hiding this comment.
what is metadata used for for outbound?
Contributor
Author
There was a problem hiding this comment.
It is defined on the Outbound trunk, but I can't find any usage of it. Intent may have been to set a default value for the ParticipantMetadata, but I'm not sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.