Skip to content

add frameSizeMs to AudioStream #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theomonnom merged 9 commits into from
Jun 14, 2025
Merged

add frameSizeMs to AudioStream #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
15a4cf5
wip
theomonnom Jun 10, 2025
762ba76
Update audio_stream.ts
theomonnom Jun 10, 2025
27300ed
Update rust-sdks
theomonnom Jun 10, 2025
23ab41e
Update audio_stream.ts
theomonnom Jun 10, 2025
5eb89b7
wip
theomonnom Jun 14, 2025
bd35b22
pretty
theomonnom Jun 14, 2025
c56023d
fix version of proto
theomonnom Jun 14, 2025
c5a55bd
Merge branch 'main' into theo/frame-size-ms
theomonnom Jun 14, 2025
c8d8e68
mmh..
theomonnom Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/livekit-rtc/generate_proto.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,5 @@ PATH=$PATH:$(pwd)/node_modules/.bin \
$FFI_PROTOCOL/e2ee.proto \
$FFI_PROTOCOL/stats.proto \
$FFI_PROTOCOL/rpc.proto \
$FFI_PROTOCOL/track_publication.proto
$FFI_PROTOCOL/track_publication.proto \
$FFI_PROTOCOL/data_stream.proto
2 changes: 1 addition & 1 deletion packages/livekit-rtc/rust-sdks
Open in desktop
Submodule rust-sdks updated 25 files
+59 −0 .github/workflows/release.yml
+6 −2 .github/workflows/webrtc-builds.yml
+4 −4 Cargo.lock
+4 −4 Cargo.toml
+11 −1 README.md
+5 −5 examples/wgpu_room/Cargo.toml
+2 −2 examples/wgpu_room/src/app.rs
+2 −2 examples/wgpu_room/src/main.rs
+4 −2 examples/wgpu_room/src/video_grid.rs
+18 −18 examples/wgpu_room/src/video_renderer.rs
+14 −0 libwebrtc/CHANGELOG.md
+1 −1 libwebrtc/Cargo.toml
+2 −2 livekit-api/Cargo.toml
+3 −3 livekit-ffi/Cargo.toml
+2 −0 livekit-ffi/protocol/audio_frame.proto
+4 −0 livekit-ffi/src/livekit.proto.rs
+65 −18 livekit-ffi/src/server/audio_stream.rs
+10 −0 livekit/CHANGELOG.md
+1 −1 livekit/Cargo.toml
+1 −1 livekit/src/room/participant/local_participant.rs
+131 −2 livekit/src/rtc_engine/rtc_session.rs
+52 −0 release-plz.toml
+16 −0 webrtc-sys/CHANGELOG.md
+1 −1 webrtc-sys/Cargo.toml
+1 −1 webrtc-sys/build/src/lib.rs
4 changes: 4 additions & 0 deletions packages/livekit-rtc/src/audio_stream.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export interface AudioStreamOptions {
noiseCancellation?: NoiseCancellationOptions;
sampleRate?: number;
numChannels?: number;
frameSizeMs?: number;
}

export interface NoiseCancellationOptions {
Expand All @@ -26,6 +27,7 @@ class AudioStreamSource implements UnderlyingSource<AudioFrame> {
private sampleRate: number;
private numChannels: number;
private ncOptions?: NoiseCancellationOptions;
private frameSizeMs?: number;

constructor(
track: Track,
Expand All @@ -36,6 +38,7 @@ class AudioStreamSource implements UnderlyingSource<AudioFrame> {
this.sampleRate = sampleRateOrOptions.sampleRate ?? 48000;
this.numChannels = sampleRateOrOptions.numChannels ?? 1;
this.ncOptions = sampleRateOrOptions.noiseCancellation;
this.frameSizeMs = sampleRateOrOptions.frameSizeMs;
} else {
this.sampleRate = (sampleRateOrOptions as number) ?? 48000;
this.numChannels = numChannels ?? 1;
Expand All @@ -46,6 +49,7 @@ class AudioStreamSource implements UnderlyingSource<AudioFrame> {
trackHandle: track.ffi_handle.handle,
sampleRate: this.sampleRate,
numChannels: this.numChannels,
frameSizeMs: this.frameSizeMs,
...(this.ncOptions
? {
audioFilterModuleId: this.ncOptions.moduleId,
Expand Down
12 changes: 12 additions & 0 deletions packages/livekit-rtc/src/proto/audio_frame_pb.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,11 @@ export class NewAudioStreamRequest extends Message<NewAudioStreamRequest> {
*/
audioFilterOptions?: string;

/**
* @generated from field: optional uint32 frame_size_ms = 7;
*/
frameSizeMs?: number;

constructor(data?: PartialMessage<NewAudioStreamRequest>) {
super();
proto2.util.initPartial(data, this);
Expand All @@ -225,6 +230,7 @@ export class NewAudioStreamRequest extends Message<NewAudioStreamRequest> {
{ no: 4, name: "num_channels", kind: "scalar", T: 13 /* ScalarType.UINT32 */, opt: true },
{ no: 5, name: "audio_filter_module_id", kind: "scalar", T: 9 /* ScalarType.STRING */, opt: true },
{ no: 6, name: "audio_filter_options", kind: "scalar", T: 9 /* ScalarType.STRING */, opt: true },
{ no: 7, name: "frame_size_ms", kind: "scalar", T: 13 /* ScalarType.UINT32 */, opt: true },
]);

static fromBinary(bytes: Uint8Array, options?: Partial<BinaryReadOptions>): NewAudioStreamRequest {
Expand Down Expand Up @@ -320,6 +326,11 @@ export class AudioStreamFromParticipantRequest extends Message<AudioStreamFromPa
*/
audioFilterOptions?: string;

/**
* @generated from field: optional uint32 frame_size_ms = 9;
*/
frameSizeMs?: number;

constructor(data?: PartialMessage<AudioStreamFromParticipantRequest>) {
super();
proto2.util.initPartial(data, this);
Expand All @@ -335,6 +346,7 @@ export class AudioStreamFromParticipantRequest extends Message<AudioStreamFromPa
{ no: 6, name: "num_channels", kind: "scalar", T: 13 /* ScalarType.UINT32 */, opt: true },
{ no: 7, name: "audio_filter_module_id", kind: "scalar", T: 9 /* ScalarType.STRING */, opt: true },
{ no: 8, name: "audio_filter_options", kind: "scalar", T: 9 /* ScalarType.STRING */, opt: true },
{ no: 9, name: "frame_size_ms", kind: "scalar", T: 13 /* ScalarType.UINT32 */, opt: true },
]);

static fromBinary(bytes: Uint8Array, options?: Partial<BinaryReadOptions>): AudioStreamFromParticipantRequest {
Expand Down
Loading
Loading