Skip to content

do not mix changesets#498

Merged
davidzhao merged 2 commits into
mainfrom
fix-changesets
Jun 23, 2025
Merged

do not mix changesets#498
davidzhao merged 2 commits into
mainfrom
fix-changesets

Conversation

@davidzhao

@davidzhao davidzhao commented Jun 23, 2025

Copy link
Copy Markdown
Member

including private packages was causing changesets to fail

@changeset-bot

changeset-bot Bot commented Jun 23, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b8f591b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 8 packages
Name Type
livekit-server-sdk Patch
@livekit/rtc-node Patch
agent-dispatch Patch
@livekit/rtc-node-darwin-arm64 Patch
@livekit/rtc-node-darwin-x64 Patch
@livekit/rtc-node-linux-arm64-gnu Patch
@livekit/rtc-node-linux-x64-gnu Patch
@livekit/rtc-node-win32-x64-msvc Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lukasIO lukasIO left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From their docs, it appears that the "correct" way of handling packages that should not be published is to simply set private: true in package.json and not add them to the ignored packages in the changesets config, for reference

@davidzhao

Copy link
Copy Markdown
Member Author

From their docs, it appears that the "correct" way of handling packages that should not be published is to simply set private: true in package.json and not add them to the ignored packages in the changesets config, for reference

that makes sense.. looks like all of the examples here have been set as "private": "true"... which might be why it's busted

@davidzhao davidzhao merged commit 90a0a55 into main Jun 23, 2025
13 checks passed
@davidzhao davidzhao deleted the fix-changesets branch June 23, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants