Adding display name to CreateSipParticipant#544
Conversation
alexlivekit
requested review from
biglittlebigben,
cnderrauber and
davidzhao
🦋 Changeset detectedLatest commit: d1e5376 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bcherry
left a comment
bcherry
left a comment
There was a problem hiding this comment.
you need to edit the protocol dependency in the main package.json as well
| '@livekit/protocol@1.40.0': | ||
| resolution: {integrity: sha512-1q0TNqlSTDW9ZuQCYTLDusyO+StvAXPmECQgyuszThDjzhTwQOkA6Rv7B1wPcvpTcwieIG0vuAO4cw4+kg+xWA==} | ||
|
|
||
| '@livekit/protocol@1.42.0': |
There was a problem hiding this comment.
I noticed that the lockfile now has two versions of protocol specified. it seems that's because examples/agent-dispatch/package.json has its own specific dependency but it's not needed. you should remove the explicit protocol dependency from that example's package.json, add it to the main package.json, then rerun pnpm install.
bcherry
left a comment
bcherry
left a comment
There was a problem hiding this comment.
lgtm! make you run pnpm install again after last edits to ensure the lockfile is up to date
| "dependencies": { | ||
| "@livekit/protocol": "^1.42.0" | ||
| }, |
There was a problem hiding this comment.
you should be able to remove this one
2 participants
No description provided.