Skip to content

ReadyForRoomEvent + update to livekit ffi 0.12.60#666

Merged
stephen-derosa merged 5 commits into
mainfrom
sderosa/BOT-344-ready-for-room-event
May 22, 2026
Merged

ReadyForRoomEvent + update to livekit ffi 0.12.60#666
stephen-derosa merged 5 commits into
mainfrom
sderosa/BOT-344-ready-for-room-event

Conversation

@stephen-derosa

Copy link
Copy Markdown
Contributor

Overview

Send ReadyForRoomEventRequest once async connection is returned from rust.

Implications

Without this as of this commit in the rust SDK after fulfilling the async connection response, rust will timeout with a panic after 1s of not getting this request

@stephen-derosa stephen-derosa requested review from ladvoc and lukasIO May 20, 2026 22:54
@changeset-bot

changeset-bot Bot commented May 20, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 38adacd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@livekit/rtc-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@stephen-derosa

Copy link
Copy Markdown
Contributor Author

looks like my prettier stage is failing, i ran it locally but i see its unchanged -- maybe my local prettier format (default) is not what the repo uses?

❯ pnpm exec prettier --check "packages/livekit-rtc/src/room.ts"
Checking formatting...
All matched files use Prettier code style!

@lukasIO lukasIO left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

prettier should pick up the config from this repo, I pushed a fix (was just a import ordering issue), for next time you can try running pnpm run format:check and/or pnpm run format:write locally and it should work

@lukasIO lukasIO mentioned this pull request May 21, 2026
1 task

@ladvoc ladvoc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅, thanks for adding this @stephen-derosa!

@1egoman 1egoman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally with agents-js (which exercised both readyForRoomEvent and RPC v2) and everything worked as expected. In addition, the new "long rpc" case in the rpc example I added also passes.

I think this is ready to go, I will aim to get this released on monday!

@1egoman 1egoman changed the title ReadyForRoomEvent ReadyForRoomEvent + update to livekit ffi 0.12.60 May 22, 2026
@stephen-derosa stephen-derosa merged commit ab64479 into main May 22, 2026
12 checks passed
@stephen-derosa stephen-derosa deleted the sderosa/BOT-344-ready-for-room-event branch May 22, 2026 16:54
@github-actions github-actions Bot mentioned this pull request May 22, 2026
pabloFuente added a commit to pabloFuente/livekit-server-sdk-dotnet that referenced this pull request May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants