ffmpeg: abort runaway encodes when FPS/filter explodes frame count #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some inputs can trigger the FPS/filter pipeline to generate far more output frames than are actually decoded, leading to very long, disk-filling transcodes. Plumb decoded frame counts into the encoder path and, for video outputs, abort with `lpms_ERR_ENC_RUNAWAY` when encoded frames exceed 25x decoded frames, excluding `image2` inputs where expansion is expected. The exact inputs which trigger this behavior are unknown as of now but we can construct a contrived test which reproduces the issue.
j0sh
added a commit
to livepeer/go-livepeer
that referenced
this pull request
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some inputs can trigger the FPS/filter pipeline to generate far more output frames than are actually decoded, leading to very long, disk-filling transcodes.
Plumb decoded frame counts into the encoder path and, for video outputs, abort with
lpms_ERR_ENC_RUNAWAYwhen encoded frames exceed 25x decoded frames, excludingimage2inputs where expansion is expected.The exact inputs which trigger this behavior are unknown as of now but we can construct a contrived test which reproduces the issue.