Recompile cache when timestamps are equal - #206
Merged
Conversation
Contributor
Benchmark Result: Default
Median of 10 attempts, 5000 iterations x 10 rounds, 33.32s total To run a specific benchmark, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scenario
When a component source changes within the same second its compiled cache was written, Blaze can render stale output.
The problem
PHP file modification timestamps have one-second resolution, but the cache checks only consider a source stale when its modification time is greater than the compiled file:
The sequence is:
This affects both isolated rendering during folding and runtime component compilation.
The solution
Treat equal timestamps as stale, matching Laravels cache expiration behavior:
Added regression tests for both cache paths.
Follow-up to #202