Use bpf_probe_read_*_str for all string buffer reads#57
Merged
Conversation
…and chapter7 Co-authored-by: lizrice <458616+lizrice@users.noreply.github.com> Agent-Logs-Url: https://github.com/lizrice/learning-ebpf/sessions/4a8ea66b-0d3b-43f5-8b94-bfadc211cd96
Copilot
AI
changed the title
[WIP] Fix errata in array handling and tidy string output
Use bpf_probe_read_*_str for all string buffer reads
Mar 23, 2026
lizrice
approved these changes
Mar 23, 2026
Owner
|
@copilot I approved this, what happens next? |
Contributor
Author
Since this is a stacked PR on top of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpf_probe_read_kernel/userdoes not NUL-terminate when truncating, so buffers read intodata.path,data.message, anddata.commandcould contain garbage when printed as C strings in user space.Changes
bpf_probe_read_kernel/userwithbpf_probe_read_kernel_str/bpf_probe_read_user_strfor alldata.pathreads (kprobe_sys_execve,kprobe_do_execve,fentry_execve,tp_sys_enter_execve)bpf_probe_read_kernelwithbpf_probe_read_kernel_strfordata.messagein both thep != 0and fallback branches&when passing array fields to BPF helpers (arrays already decay to pointers)✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.