Repository navigation
chore: fix ruff unused imports and invalid regex escapes - #46
Merged
Merged
Conversation
- parsers_list.py: drop unused EMAIL_ATTR_FROM/SUBJECT/BODY imports. - ali_express.py, pledgebox.py, swiss_post.py: use raw strings for regexes with \. and \d (SyntaxWarning: invalid escape sequence on Python 3.12+). Behavior is unchanged: the escapes were already passed through literally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small cleanup, separate from #45.
parsers_list.py: remove 3 unused imports (EMAIL_ATTR_FROM,EMAIL_ATTR_SUBJECT,EMAIL_ATTR_BODY). This is ruff F401.ali_express.py,pledgebox.py,swiss_post.py: make the regex patterns raw strings. Python 3.12+ emitsSyntaxWarning: invalid escape sequencefor'\.'and'\d'. The regexes don't change, because the invalid escapes were already passed through literally.Testing
ruff check custom_components/tracking_numbers/parsers_list.pypasses.python3 -W error -m py_compileover the integration compiles with no warnings.python3 scripts/run_parsers.pypasses on all fixtures.parsers_list.pyare preserved.