chore(mypy): add type hints and protocol store to datasetio localfs Provider#5422
Open
Elbehery wants to merge 1 commit intollamastack:mainfrom
Open
chore(mypy): add type hints and protocol store to datasetio localfs Provider#5422Elbehery wants to merge 1 commit intollamastack:mainfrom
Elbehery wants to merge 1 commit intollamastack:mainfrom
Conversation
Elbehery
requested review from
ashwinb,
bbrowning,
cdoern,
ehhuang,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
meta-cla
bot
added
the
CLA Signed
…rovider Implement SimpleDatasetStore for DatasetIO protocol and add type annotations: - Add SimpleDatasetStore with create, delete, list dataset methods - Add type hints for dataset_infos, df, kvstore variables - Fix method signatures to use IterRowsRequest and AppendRowsParams - Fix variable shadowing (dataset → dataset_json) pyproject.toml: - Remove directory exclude for datasetio/localfs/ - Add individual file excludes for __init__.py and config.py - Update Section 2 count from 131 to 133 files - Update Providers - Inline count from 27 to 29 files Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
Elbehery
force-pushed
the
mypy-datasetio-localfs
branch
from
808e04e to
a74900b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement SimpleDatasetStore for DatasetIO protocol and add type annotations:
pyproject.toml: