Skip to content

Change reduce_value type from double to float in CudaKernelOps #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkapur17 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change reduce_value type from double to float in CudaKernelOps #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions minitorch/cuda_kernel_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def ret(a: Tensor, dim: int) -> Tensor:
np.ctypeslib.ndpointer(dtype=np.int32, ndim=1, flags='C_CONTIGUOUS'), # in_shape
np.ctypeslib.ndpointer(dtype=np.int32, ndim=1, flags='C_CONTIGUOUS'), # in_strides
ctypes.c_int, # reduce_dim
ctypes.c_double, # reduce_value
ctypes.c_float, # reduce_value
ctypes.c_int, # shape_len
ctypes.c_int, # fn_id
]
Expand Down Expand Up @@ -375,4 +375,4 @@ def matrix_multiply(a: Tensor, b: Tensor) -> Tensor:
if more_3d:
out = out.view(*ls)
# print(f"Debug in matmul: output shape {out.shape}")
return out
return out