PR Approval Process

Process for Merging PRs to Develop

• Create PR
• Submitter requests feedback
• Approvals:
  • 1 for small changes (documentation fixes, one-liners)
  • 2 for new features
• Submitter merges (@davidbeckingsale for external PRs)

Comments from #9

@ajkunen:

The person who submitted the PR should do the merge, once they feel they have gotten the feedback they were looking for (unless that person doesn't have "merge" permissions). And like we did on Stash, you need at least one "I approve" comment form someone.

@keasler:

Since the consequences are higher, and since there are more eyes on github, I think it would be nice to have two approvals. Also, I think that only one dissenter should be able to stop the process until the dissenters issue is handled to their satisfaction, or the dissenter is over-ruled by at least two people who are not the branch owner.