Open
Conversation
Location of silo-targets.cmake in the install. Ensuring HDF5's find of zlib finds the correct one if SILO_ZLIB_DIR set. Fix what gets deployed on Windows when using `windeployqt`.
Fix zlib target name in SiloFindZlib when trying to copy dll. Use HDF5_PROVIDES_ZLIB_SUPPORT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Location of silo-targets.cmake in the install.
Ensuring HDF5's find of zlib finds the correct one if SILO_ZLIB_DIR set.
Fix what gets deployed on Windows when using
windeployqt.