Task/ebchin/build warnings changes - #236
Merged
white238 merged 23 commits intoAug 13, 2026
Merged
Conversation
ebchin
commented
Aug 10, 2026
ebchin
commented
Member
- Turn on warnings as errors so we (hopefully) don't have to do this again
- Try to fix the MPI and OpenMP logic in the SetupMFEM.cmake file so we don't have to list them as dependencies in executables that depend on MFEM
- Use axom::numeric_limits::max() instead of std::numeric_limits::max() for device support
- Make spatialDimension() an int
white238
reviewed
Aug 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Enables stricter warning handling and resolves resulting compiler warnings while improving MFEM dependency propagation.
Changes:
- Enables warnings-as-errors and initializes previously uninitialized values.
- Propagates MFEM’s MPI/OpenMP dependencies.
- Standardizes spatial-dimension and device-compatible numeric-limit usage.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
CMakeLists.txt |
Enables strict compiler warnings. |
cmake/TribolCompilerFlags.cmake |
Removes trailing blank line. |
cmake/thirdparty/SetupMFEM.cmake |
Propagates MPI/OpenMP dependencies. |
src/tests/CMakeLists.txt |
Removes redundant MFEM dependencies. |
src/tests/tribol_comp_geom_3d.cpp |
Preserves cleanup before returning. |
src/tribol/geom/CompGeom.hpp |
Resolves initialization and formatting warnings. |
src/tribol/geom/GeomUtilities.hpp |
Uses device-compatible numeric limits. |
src/tribol/integ/FE.hpp |
Initializes basis values and validates bounds. |
src/tribol/mesh/CouplingScheme.hpp |
Simplifies dimension handling and initializes arrays. |
src/tribol/mesh/MeshData.hpp |
Returns spatial dimension as int. |
src/tribol/mesh/MfemData.hpp |
Aligns member documentation formatting. |
src/tribol/physics/AlignedMortar.cpp |
Initializes values and handles missing node matches. |
src/tribol/physics/ContactFormulationFactory.cpp |
Scopes feature-dependent variables correctly. |
src/tribol/physics/Mortar.cpp |
Initializes basis values. |
src/tribol/search/InterfacePairFinder.cpp |
Removes unused capture and makes helper static. |
src/tribol/utils/TestUtils.cpp |
Initializes the VTK element identifier. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
white238
reviewed
Aug 11, 2026
ebchin
force-pushed
the
task/ebchin/build_warnings_changes
branch
2 times, most recently
from
August 12, 2026 05:03
2290518 to
718c9c2
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ebchin
force-pushed
the
task/ebchin/build_warnings_changes
branch
from
August 12, 2026 16:59
a25ca9b to
1072f9c
Compare
white238
reviewed
Aug 13, 2026
| } | ||
| } | ||
| #else | ||
| TRIBOL_UNUSED_VAR( m1 ); |
Member
There was a problem hiding this comment.
any reason you dont use [[maybe_unused]]?
Member
There was a problem hiding this comment.
This could be a follow up PR across tribol
Member
Author
There was a problem hiding this comment.
No good reason. I agree -- worth cleaning up in a follow-on PR.
white238
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.