Skip to content

Fix build errors - #238

Open
white238 wants to merge 4 commits into
developfrom
bugfix/white238/hopefully_last_warnings
Open

Fix build errors#238
white238 wants to merge 4 commits into
developfrom
bugfix/white238/hopefully_last_warnings

Conversation

@white238

@white238 white238 commented Aug 18, 2026

Copy link
Copy Markdown
Member

Fixes:

src/tribol/geom/CompGeom.hpp:1524:19: error: declaration of ‘max_nodes_per_overlap’ shadows a member of ‘tribol::CommonPlanePair’ [-Werror=shadow]
 1524 |     constexpr int max_nodes_per_overlap = 10;
      |                   ^~~~~~~~~~~~~~~~~~~~~
src/tribol/geom/CompGeom.hpp:89:24: note: shadowed declaration is here
   89 |   static constexpr int max_nodes_per_overlap{ 10 };
      |                        ^~~~~~~~~~~~~~~~~~~~~

Fixes:

CMakeFiles/shared_par_sparse_mat_test.dir/shared_par_sparse_mat.cpp.o: undefined reference to symbol '_ZN4axom4slic10initializeEb'

@white238
white238 requested review from ebchin and srwopschall and a lite review from Copilot August 18, 2026 02:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a local constexpr that shadowed tribol::CommonPlanePair::max_nodes_per_overlap, addressing a -Werror=shadow build failure in CommonPlanePair::resetPlanePointAndCentroidGap.

Changes:

  • Deleted the function-local max_nodes_per_overlap constant so the member CommonPlanePair::max_nodes_per_overlap is used consistently.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ebchin

ebchin commented Aug 18, 2026

Copy link
Copy Markdown
Member

Thanks @white238

@srwopschall srwopschall left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @white238

@white238 white238 changed the title remove shadowed variable Fix build errors Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants