Add warning as error to release build Gitlab CI jobs - #1918
Open
bmhan12 wants to merge 8 commits into
Open
Conversation
bmhan12
added
Testing
bmhan12
commented
Jul 15, 2026
Comment on lines
-424
to
-425
| // Note: gcc@10.3.1 emits a '-Warray-bounds' warning in callers of this function | ||
| // about the sizes of nodeIds and coords not matching due to the runtime switch on dimension |
Contributor
Author
There was a problem hiding this comment.
This is the primary issue these mint changes are resolving.
bmhan12
requested review from
Arlie-Capps,
BradWhitlock,
jcs15c,
kennyweiss,
nselliott,
publixsubfan,
rhornung67 and
white238
July 15, 2026 17:14
rhornung67
reviewed
Jul 15, 2026
Arlie-Capps
approved these changes
Jul 24, 2026
Arlie-Capps
left a comment
Arlie-Capps
left a comment
Contributor
There was a problem hiding this comment.
Thank you for these fixes, @bmhan12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
mint) to eliminate warnings.