Adds a bump-based Marching Cubes option - #1950
Draft
kennyweiss wants to merge 19 commits into
Draft
Conversation
…d implementation as legacy The original implementation only supported structured input meshes. This implementation leverages bump's support for both structured and unstructured inputs.
…ed on all exec spaces
And improves some documentation.
All of MC depends on conduit and the bump Impl/Adapter also depend on bump. The example now depends on bump. Also includes some misc. formatting and doxygen changes.
... instead of keeping it in global state. Also uses RAII for the logger instead of an explicit initialize/finalize call, and adds some misc formatting/comment changes.
Tests the different orderings and checks that the results match expectations.
…eprint It was previously hard-coded to only support multidomain blueprint. Also adds a python script to generate single domain marching cubes blueprint meshes.
Work for bump/legacy, structured/unstructured, single/multi domain.
…cells After checking the labels, we know which zones contributes cells to the extracted surface. Store those in a list to avoid extra work.
Adds faster path for edge labelings on structured meshes. Also reserves the hash map size in bump::Unique.
kennyweiss
added
Quest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bump-based Marching Cubes option to quest to run on structured and unstructured meshesTODO: