Adds Gregory surfaces to primal - #1951
Open
jcs15c wants to merge 20 commits into
Open
Conversation
jcs15c
added
enhancement
…m/LLNL/axom into feature/spainhour/gregory_patches
jcs15c
marked this pull request as ready for review
August 24, 2026 20:46
jcs15c
requested review from
Arlie-Capps,
BradWhitlock,
bmhan12,
kennyweiss and
rhornung67
August 24, 2026 20:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
GregoryPatchandGregoryTriangleclasses to primal, which are surface objects which can be defined only through a set of boundary curves and tangent vectors at the interior control points of those curves. The classes are meant to mirrorBezierPatchandBezierTrianglerespectively. These changes will be followed by methods that do more interesting things to Gregory patches, such as ray-casting and/or winding numbers methods.This has required minor changes to other geometric objects: