Adds callback support to Klee's Lua input - #1962
Open
kennyweiss wants to merge 52 commits into
Open
Conversation
kennyweiss
requested review from
Arlie-Capps,
BradWhitlock,
adayton1,
bmhan12,
jcs15c,
publixsubfan,
rhornung67 and
white238
August 25, 2026 03:34
kennyweiss
force-pushed
the
feature/kweiss/klee-lua-callbacks
branch
from
August 27, 2026 05:32
60d7019 to
353e98e
Compare
Converted some SLIC_ERROR() calls to throwing exceptions so we can provide better error handling.
…deck Users can pass in a lua table containing variables and functions.
Adds inlet::KleeReader::shouldTreatFunctionAsNotFound() as a way to override default behavior. This defaults to false, but is overriden by klee to allow functions for scalars/maps.
Specifically, the variables can be modified within the deck.
* Removed scalar->vector coersion. Need to return a table with one entry rather than a scalar * Stop storing name for operators. They were not used * Removed unreachable duplicate export extraction
Bindings operate in isolated environment so they don't inherit or affect the global state.
This avoids extra calls for variables vs. tabular Lua input.
We have to explicitly register which paths can contain callbacks with inlet.
* Tags function alternatives as internal Sidre groups so restart reconstruction doesn't expose callback storage as ordinary fields * Reject multiple callback alternatives for the same input path and documents this
… first We previously overcomplicated the solution to allow order independence, which does not seem necessary. The simplified approach allows us to treat the result as an ordinary function.
Only support a Lua table as input, not a ket/value map.
… callback evaluation And documents when we use SLIC_ERROR/SLIC_WARNING vs. validation checks vs. throwing.
And adds a minor missing one.
kennyweiss
force-pushed
the
feature/kweiss/klee-lua-callbacks
branch
from
August 28, 2026 01:29
353e98e to
b3663e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addFunctionAsValueAlternative()TODO