Skip to content

save mfem's tpl rpath info by transforming -Xlinker items to -Wl #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chapman39 wants to merge 4 commits into
base: develop
Choose a base branch
from
+4 −3
Open

save mfem's tpl rpath info by transforming -Xlinker items to -Wl #1968

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d055e7
save mfem's tpl rpath info by transforming -Xlinker items to -Wl
chapman39 Aug 27, 2026
4c9447b
formatting
chapman39 Aug 27, 2026
457975f
Merge branch 'develop' into bugfix/chapman39/replace-xlinker-with-wl-…
chapman39 Aug 27, 2026
b50e831
Merge branch 'develop' into bugfix/chapman39/replace-xlinker-with-wl-…
bmhan12 Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/cmake/thirdparty/FindMFEM.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,12 @@ else()
string(SUBSTRING "${mfem_tpl_lnk_flags}" 0 ${mfem_tpl_lnl_flags_end_pos} mfem_tpl_lnk_flags)
string(STRIP "${mfem_tpl_lnk_flags}" mfem_tpl_lnk_flags)

# filter out items containing "Xlinker"
# transform -Xlinker items to -Wl
set(_mfem_tpl_list ${mfem_tpl_lnk_flags})
separate_arguments(_mfem_tpl_list)
list(FILTER _mfem_tpl_list EXCLUDE REGEX Xlinker)
list(JOIN _mfem_tpl_list " " mfem_tpl_lnk_flags)
list(TRANSFORM _mfem_tpl_list
REPLACE "^-Xlinker=-rpath,(.*)$" "-Wl,-rpath,\\1")
set(mfem_tpl_lnk_flags ${_mfem_tpl_list})
Comment on lines 116 to +120

@chapman39 chapman39 Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah but mfem doesnt.

else()
message(WARNING "No third party library flags found in ${MFEM_CFG_DIR}/config.mk")
endif()
Expand Down