add specialization for zero-sized array - #227
Open
gberg617 wants to merge 2 commits into
Open
Conversation
gberg617
commented
Aug 31, 2026
| } | ||
|
|
||
| template <class T> | ||
| CAMP_HOST_DEVICE inline constexpr bool operator<(const array<T, 0>&, |
Collaborator
Author
There was a problem hiding this comment.
Note: C++20 replaces most of these comparison operators with the three-way comparison <=> operator
adayton1
reviewed
Aug 31, 2026
|
|
||
| CAMP_TEST_BEGIN(array, empty) | ||
| { | ||
| // Zero sized arrays are technically not allowed, |
Member
There was a problem hiding this comment.
Can add a check on the return value of empty() for a zero length array?
Member
There was a problem hiding this comment.
Or if you already check it above, just remove this comment.
adayton1
reviewed
Aug 31, 2026
|
|
||
| CAMP_TEST_BEGIN(array, size) | ||
| { | ||
| // Zero sized arrays are technically not allowed, |
Member
There was a problem hiding this comment.
Can you add a check for size on zero length array? Or if that's already checked above, just remove this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.