[Fix] Flattening atomic strings in groupby#46
Merged
rayandrew merged 1 commit intollnl:developfrom Feb 14, 2026
Merged
Conversation
…_flatten with string handling
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the betterset dependency and adds a regression test to ensure unique_set_flatten correctly handles string values during multi-stage Dask DataFrame aggregations (avoiding unintended character-wise flattening).
Changes:
- Bump
bettersetminimum version from0.1.0to0.2.0. - Add a Dask aggregation test covering string values for
unique_set_flatten.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/utils/test_dask_agg.py |
Adds coverage for unique_set_flatten with string-valued columns in a multi-stage groupby/agg pipeline. |
pyproject.toml |
Updates the minimum required betterset version to pick up the fix/behavior needed for correct string flattening. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rayandrew
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates a dependency and adds a new test to improve coverage for string handling in Dask aggregation utilities.
Dependency update:
bettersetdependency version requirement from>=0.1.0to>=0.2.0inpyproject.toml, ensuring compatibility with the latest features and bug fixes.Testing improvements:
test_unique_set_flatten_handles_strings_via_dask, to verify that theunique_set_flattenaggregation correctly handles string values when used with Dask DataFrames.