Add view-scoped additional metrics and console reporting#50
Merged
hariharan-devarajan merged 1 commit intollnl:developfrom Mar 5, 2026
Merged
Conversation
hariharan-devarajan
approved these changes
Mar 5, 2026
Member
hariharan-devarajan
left a comment
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for handling and displaying additional metrics in the analyzer output, with changes spanning configuration, processing, and presentation. The main improvements include refactoring the configuration for additional metrics to support per-view-type metrics, updating the analysis pipeline to process these metrics correctly, and adding a new summary table for additional metrics in the output.
Configuration and Data Model Updates
AnalyzerPresetConfigdataclass to allow specifying additional metrics as a dictionary mapping view types to their respective metrics, enabling more granular control over which metrics are tracked for each view type.AnalyzerResultTypedataclass to include anadditional_metricsfield, which stores the list of additional metrics for each view type.Analysis Pipeline Changes
_analyze_hlmand_process_flat_viewmethods inanalyzer.pyto correctly pass and process additional metrics per view type, ensuring metrics are set and evaluated based on the view type rather than globally. [1] [2]Output and Presentation Enhancements
_create_additional_metrics_tablemethod tooutput.py, which generates a summary table for additional metrics including unit conversion, non-null counts, and basic statistics (min, mean, max) for each metric. The table is conditionally displayed if additional metrics are present for the current view. [1] [2]output.pyto support new unit handling and calculations for additional metrics.