This repository was archived by the owner on Nov 10, 2024. It is now read-only.
Preliminary CARE stack - #14
Closed
tldahlgren wants to merge 3 commits into
Closed
Conversation
| ############################################################################## | ||
|
|
||
| spack: | ||
| #[general--] |
Member
There was a problem hiding this comment.
Those comments are delimiters for documentation, no need to keep them outside of the original file.
Comment on lines
+60
to
+66
| ## quartz | ||
| ## [runner-mapping--] | ||
| #- match: | ||
| # - target=broadwell | ||
| # runner-attributes: | ||
| # tags: [quartz, shell] | ||
| ## [--runner-mapping] |
Member
There was a problem hiding this comment.
I think your intent is not to have a quartz pipeline. But in fact the quartz generation still happens, so it may fail in the end.
I suggest commenting out the quartz jobs in the CI for now, in an isolated commit that we can revert later on.
Member
|
@tldahlgren In .gitlab/get-spack script the ref is expected to be a branch. Could you modify it so that it also accepts commits? I am guessing that just removing "--branch" could work, but did not verify. This is something you can test locally, you don’t have to trigger the CI for this. |
Collaborator
Author
|
Replacing with #16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan on replacing this PR with #16