Repository navigation
Harden descriptor validation and improve resource handling - #42
Merged
lloydsmart merged 4 commits intoAug 5, 2026
Merged
Conversation
lloydsmart
marked this pull request as ready for review
August 5, 2026 10:22
lloydsmart
deleted the
bugfix/descriptor-archive-validation-and-resources
branch
August 5, 2026 10:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chdmanthread selectionsynccalls, and fixed sleepsWhy
Descriptor references were resolved too loosely, companion files were not consistently validated, and archives could reach extraction without sufficient path and collision preflight. Resource selection also counted swap as usable compression memory and forced hunk sizes without measured justification.
The new validation builds a safe, complete source set before conversion or cleanup. Resource defaults now defer format-specific hunk sizing to
chdmanand select conservative concurrency from currently available physical memory.Impact
Unsafe, incomplete, or ambiguous descriptor/archive inputs now fail before
chdmanruns and retain their originals. Successful direct descriptor conversions remove the validated source set together unless--keep-originalsis enabled.Advanced users can set
CHDMAN_THREADSandCHDMAN_HUNK_SIZE; thread counts remain CPU-bounded. Dry-run output reports the effective direct-input command.Validation
shellcheck chdtool.sh tests/*.sh tests/bin/*Fixes #32.
Fixes #31.