Skip to content

Attachments and Embeds Bugfix and Improvements #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
llsc12 wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Attachments and Embeds Bugfix and Improvements #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7fb21f2
fix performance issues, add mosaic to embeds
llsc12 Feb 12, 2026
16514e3
specialised corner radius on embed mosaics
llsc12 Feb 12, 2026
290d173
fix missed rows
llsc12 Feb 12, 2026
51c1d78
move gifv
llsc12 Feb 12, 2026
e4b10da
Merge branch 'main' into attachments
llsc12 Feb 17, 2026
2e33f4e
slight performance improvements
llsc12 Feb 18, 2026
2bb6ad5
attachment viewer work
llsc12 Feb 27, 2026
7d4963b
Update AttachmentViewer.swift
llsc12 Feb 27, 2026
b3a2e4d
scroll limits when zoomed in
llsc12 Mar 1, 2026
ae7130c
ios bounds
llsc12 Mar 1, 2026
1973a60
Update AttachmentViewer.swift
llsc12 Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions Paicord.xcworkspace/xcuserdata/llsc12.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,38 +3,4 @@
uuid = "3C51FC77-CE2B-4F32-B3F3-96CDC8C1DACC"
type = "0"
version = "2.0">
<Breakpoints>
<BreakpointProxy
BreakpointExtensionID = "Xcode.Breakpoint.FileBreakpoint">
<BreakpointContent
uuid = "84B43BBA-BA2F-45B8-9176-7AEAF325BA43"
shouldBeEnabled = "Yes"
ignoreCount = "0"
continueAfterRunningActions = "No"
filePath = "Paicord/Common/Login/LoginViewModel.swift"
startingColumnNumber = "9223372036854775807"
endingColumnNumber = "9223372036854775807"
startingLineNumber = "19"
endingLineNumber = "19"
landmarkName = "init()"
landmarkType = "7">
</BreakpointContent>
</BreakpointProxy>
<BreakpointProxy
BreakpointExtensionID = "Xcode.Breakpoint.FileBreakpoint">
<BreakpointContent
uuid = "87CFA371-3835-4845-A475-D49E941DFDC7"
shouldBeEnabled = "Yes"
ignoreCount = "0"
continueAfterRunningActions = "No"
filePath = "Paicord/Common/Login/LoginViewModel.swift"
startingColumnNumber = "9223372036854775807"
endingColumnNumber = "9223372036854775807"
startingLineNumber = "28"
endingLineNumber = "28"
landmarkName = "init()"
landmarkType = "7">
</BreakpointContent>
</BreakpointProxy>
</Breakpoints>
</Bucket>
6 changes: 6 additions & 0 deletions Paicord/App/PaicordAppState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ final class PaicordAppState {

// MARK: - General
var showingQuickSwitcher: Bool = false

// MARK: - Attachment Viewer
var showingAttachmentViewer: Bool = false
var attachmentViewerAttachments: [DiscordMedia] = []
var attachmentViewerIndex: Int? = nil
var attachmentViewerContextMessage: DiscordChannel.PartialMessage? = nil

// MARK: - Selected Guild & Channel Persistence

Expand Down
1 change: 1 addition & 0 deletions Paicord/App/RootView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ struct RootView: View {
.quickSwitcher()
.sponsorSheet()
.updateSheet()
.attachmentViewer()
.task {
appState.loadPrevGuild()
#if os(iOS)
Expand Down
2 changes: 1 addition & 1 deletion Paicord/Common/Chat/ChatView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ struct ChatView: View {
name: .chatViewShouldScrollToBottom,
object: ["channelId": vm.channelId, "immediate": true]
)
InputBar.inputVMs[vm.channelId]?.uploadItems = []
return .handled
}
.introspect(.scrollView, on: .macOS(.v14...)) { scrollView in
Expand Down Expand Up @@ -204,7 +205,6 @@ struct ChatView: View {
.scrollDismissesKeyboard(.interactively)
.background(theme.common.secondaryBackground)
.ignoresSafeArea(.keyboard, edges: .all)

#if os(macOS)
.onDisappear {
if let observer = scrollObserver {
Expand Down
Loading