Conversation
Owner
Author
|
CI gate confirmed: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Demonstrates that the CI gate configured in HEL-4 + HEL-8 actually blocks merge when CI fails.
This PR introduces a deliberate type error in
app/page.tsx(assigning astringliteral to anumber-typed variable). Thetypecheckstep should fail, the overallcistatus check should befailure, and the protectedmainbranch should refuse this merge.Will be closed without merging once we've captured the failing status.
Test plan
install / lint / typecheck / build / smokereports failure